Issue 51523002: Fix js_test in dart2js checked mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 51523002: Fix js_test in dart2js checked mode (Closed)

Created:
7 years, 1 month ago by justinfagnani

Modified:
7 years, 1 month ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix js_test in dart2js checked mode BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=29511

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	sdk/lib/js/dart2js/js_dart2js.dart	View		3 chunks	+10 lines, -6 lines	2 comments	Download
	M	tests/html/html.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://codereview.chromium.org/51523002/diff/1/sdk/lib/js/dart2js/js_dart2js.dart File sdk/lib/js/dart2js/js_dart2js.dart (right): https://codereview.chromium.org/51523002/diff/1/sdk/lib/js/dart2js/js_dart2js.dart#newcode380 sdk/lib/js/dart2js/js_dart2js.dart:380: if (index is num && index == index.toInt()) ...

7 years, 1 month ago (2013-10-29 22:08:03 UTC) #2

justinfagnani

https://codereview.chromium.org/51523002/diff/1/sdk/lib/js/dart2js/js_dart2js.dart File sdk/lib/js/dart2js/js_dart2js.dart (right): https://codereview.chromium.org/51523002/diff/1/sdk/lib/js/dart2js/js_dart2js.dart#newcode380 sdk/lib/js/dart2js/js_dart2js.dart:380: if (index is num && index == index.toInt()) { ...

7 years, 1 month ago (2013-10-30 02:16:35 UTC) #3

justinfagnani

7 years, 1 month ago (2013-10-30 02:21:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r29511 (presubmit successful).

Expand Messages | Collapse Messages