Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 514983002: Fix warning in build (Closed)

Created:
6 years, 3 months ago by siva
Modified:
6 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix warning in build ../../dart/runtime/vm/object.h:723:25: warning: passing NULL to non-pointer argument 1 of ‘void dart::Object::set_vtable(dart::cpp_vtable)’ [-Wconversion-null] obj->set_vtable(NULL); ^ R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/object.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
asiva@google.com changed reviewers: + iposva@google.com
6 years, 3 months ago (2014-08-27 23:31:19 UTC) #1
siva
6 years, 3 months ago (2014-08-27 23:31:19 UTC) #2
Ivan Posva
lgtm
6 years, 3 months ago (2014-08-27 23:32:01 UTC) #3
siva
6 years, 3 months ago (2014-08-28 00:21:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r39628 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698