Hook async/await compiler into pub and use it.

Hook async/await compiler into pub and use it.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39623

[Bob Nystrom, 2014-08-27 19:59:36]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[Bob Nystrom, 2014-08-27 19:59:36]

This hooks the real async/await compiler into pub's little bootstrap process.

Then I made a couple of trivial uses of it in a few pub source files. I've got
some more code converted to use async/await, but I want to land a minimal patch
first and flush out any bugs it causes before sending out more refactorings.

[nweiz, 2014-08-27 20:10:07]

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/bin/as...
File sdk/lib/_internal/pub/bin/async_compile.dart (right):

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:81: // have preprocessor comments
that get discarded by the compiler.
Maybe factor this into a function so you can short-circuit here?

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:94: // Do nothing. This may happen
if two instances of the compiler are running
Long lines.

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:96: // the output may fail if the
file is still open. Since they are producing
"write the output" -> "delete the file"

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/build.dart (right):

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/build.dart:130: if (mode ==
BarbackMode.RELEASE && asset.id.extension == ".dart") return;
The analyzer will complain if this isn't "return null".

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/global_run.dart (right):

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/global_run.dart:44: return
flushThenExit(exitCode);
Nit: I like using "await" rather than "return" here since the return value is
irrelevant.

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/run.dart (right):

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/run.dart:41: flushThenExit(exitCode);
We should await on this.

[Bob Nystrom, 2014-08-27 21:35:32]

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/bin/as...
File sdk/lib/_internal/pub/bin/async_compile.dart (right):

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:81: // have preprocessor comments
that get discarded by the compiler.
On 2014/08/27 20:10:07, nweiz wrote:
> Maybe factor this into a function so you can short-circuit here?

Done.

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:94: // Do nothing. This may happen
if two instances of the compiler are running
On 2014/08/27 20:10:07, nweiz wrote:
> Long lines.

Done.

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:96: // the output may fail if the
file is still open. Since they are producing
On 2014/08/27 20:10:07, nweiz wrote:
> "write the output" -> "delete the file"

Done.

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/build.dart (right):

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/build.dart:130: if (mode ==
BarbackMode.RELEASE && asset.id.extension == ".dart") return;
On 2014/08/27 20:10:07, nweiz wrote:
> The analyzer will complain if this isn't "return null".

I'm not sure if that's the case. I'll start an email thread to discuss. This
function will return a future, even here, so I don't think a null should be
necessary.

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/global_run.dart (right):

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/global_run.dart:44: return
flushThenExit(exitCode);
On 2014/08/27 20:10:07, nweiz wrote:
> Nit: I like using "await" rather than "return" here since the return value is
> irrelevant.

Done.

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/run.dart (right):

https://codereview.chromium.org/514853003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/run.dart:41: flushThenExit(exitCode);
On 2014/08/27 20:10:07, nweiz wrote:
> We should await on this.

Done.

[nweiz, 2014-08-27 21:40:59]

lgtm

[Bob Nystrom, 2014-08-27 21:43:39]

Committed patchset #2 (id:20001) manually as 39623 (presubmit successful).