Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 51393004: Remove deprecated second argument to SendPort.send(). (Closed)

Created:
7 years, 1 month ago by floitsch
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan
Visibility:
Public.

Description

Remove deprecated second argument to SendPort.send(). R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29836

Patch Set 1 #

Patch Set 2 : Inline method. #

Patch Set 3 : Update isolate.dart. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M runtime/lib/isolate_patch.dart View 1 2 chunks +3 lines, -7 lines 0 comments Download
M sdk/lib/_internal/lib/isolate_helper.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/isolate/isolate.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js_extra/runtime_type_isolate.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/browser/typed_data_message_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/isolate/isolate_complex_messages_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/standalone/io/http_advanced_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/standalone/io/http_basic_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_read_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/standalone/io/socket_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
7 years, 1 month ago (2013-11-01 23:41:18 UTC) #1
Anders Johnsen
This is not removing the argument from 'sdk/lib/isolate/isolate.dart'. However, the other changes are LGTM.
7 years, 1 month ago (2013-11-04 10:26:21 UTC) #2
floitsch
Must have forgotten to save...
7 years, 1 month ago (2013-11-04 18:38:40 UTC) #3
floitsch
7 years, 1 month ago (2013-11-04 19:01:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r29836 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698