Raise an exception instead of crashing when attempting to pass a MirrorReference between isolates.

Raise an exception instead of crashing when attempting to pass a MirrorReference between isolates.

Fix warnings in isolate illegal values tests.

BUG=http://dartbug.com/14584
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29694

[rmacnak, 2013-10-29 20:54:33]

Turns out predefined classes don't go through CheckIfSerializable. Mimicking the
pattern for Stacktrace instead.

[siva, 2013-10-31 17:39:41]

LGTM with one comment.

https://codereview.chromium.org/51393002/diff/1/runtime/vm/raw_object_snapsho...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/51393002/diff/1/runtime/vm/raw_object_snapsho...
runtime/vm/raw_object_snapshot.cc:2657: if (kind == Snapshot::kFull) {
this should be both kFull and kScript right.

Alternately you could invert the condition as
if (kind == Snapshot::kMessage) {
   ....
   ...
} else {
   UNREACHABLE();
}

[rmacnak, 2013-10-31 20:36:02]

On 2013/10/31 17:39:41, siva wrote:
> LGTM with one comment.
> 
>
https://codereview.chromium.org/51393002/diff/1/runtime/vm/raw_object_snapsho...
> File runtime/vm/raw_object_snapshot.cc (right):
> 
>
https://codereview.chromium.org/51393002/diff/1/runtime/vm/raw_object_snapsho...
> runtime/vm/raw_object_snapshot.cc:2657: if (kind == Snapshot::kFull) {
> this should be both kFull and kScript right.
> 
> Alternately you could invert the condition as
> if (kind == Snapshot::kMessage) {
>    ....
>    ...
> } else {
>    UNREACHABLE();
> }

Done.

[rmacnak, 2013-10-31 20:36:40]

Committed patchset #2 manually as r29694 (presubmit successful).