In the analysis server API, change RequestError.code to an enum.

In the analysis server API, change RequestError.code to an enum.

Some of the error codes that were previously defined are no longer
used, so those have been removed.  The enum reflects the set of errors
that are currently in use.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39689

[Paul Berry, 2014-08-27 17:08:49]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2014-08-27 17:35:41]

LGTM

[Brian Wilkerson, 2014-08-27 21:05:22]

LGTM once the values are cleaned up

https://codereview.chromium.org/513853002/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/513853002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:2581:
<code>GET_ERRORS_ERROR</code>
This seems rather vague. Any chance we can be more specific about the nature of
the error? If not, then perhaps something more general to make it clear that we
can't be specific, such as REQUEST_ERROR.

https://codereview.chromium.org/513853002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:2600:
<code>SERVER_ALREADY_STARTED</code>
Are you planning on removing this and the following value in a later CL?

https://codereview.chromium.org/513853002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:2626:
<code>UNSUPPORTED_FEATURE</code>
Not clear to me how this differs from UNKNOWN_REQUEST, probably because I don't
know what "feature" means in this context.

[Paul Berry, 2014-08-29 07:30:21]

https://codereview.chromium.org/513853002/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/513853002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:2581:
<code>GET_ERRORS_ERROR</code>
On 2014/08/27 21:05:22, Brian Wilkerson wrote:
> This seems rather vague. Any chance we can be more specific about the nature
of
> the error? If not, then perhaps something more general to make it clear that
we
> can't be specific, such as REQUEST_ERROR.

Agreed.  I've added a TODO comment.

https://codereview.chromium.org/513853002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:2600:
<code>SERVER_ALREADY_STARTED</code>
On 2014/08/27 21:05:21, Brian Wilkerson wrote:
> Are you planning on removing this and the following value in a later CL?

Yes.

https://codereview.chromium.org/513853002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:2626:
<code>UNSUPPORTED_FEATURE</code>
On 2014/08/27 21:05:21, Brian Wilkerson wrote:
> Not clear to me how this differs from UNKNOWN_REQUEST, probably because I
don't
> know what "feature" means in this context.

I don't know either.  I've added a TODO comment to remind us to clean this up.

[Paul Berry, 2014-08-29 07:30:58]

Committed patchset #1 manually as 39689 (presubmit successful).