Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 51353011: Make Dart heap size bigger when running pub. (Closed)

Created:
7 years, 1 month ago by Bob Nystrom
Modified:
7 years ago
Reviewers:
nweiz, Søren Gjesse
CC:
reviews_dartlang.org, dgrove
Visibility:
Public.

Description

Make Dart heap size bigger when running pub. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=29866

Patch Set 1 #

Patch Set 2 : Bump heap in tests too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M sdk/bin/pub View 2 chunks +6 lines, -2 lines 0 comments Download
M sdk/bin/pub_developer View 2 chunks +7 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
7 years, 1 month ago (2013-11-05 00:00:37 UTC) #1
nweiz
lgtm
7 years, 1 month ago (2013-11-05 00:05:30 UTC) #2
Bob Nystrom
Committed patchset #2 manually as r29866 (presubmit successful).
7 years, 1 month ago (2013-11-05 01:14:09 UTC) #3
Søren Gjesse
Bob, what about the Windows batch file pub.bat?
7 years, 1 month ago (2013-11-05 06:57:37 UTC) #4
Bob Nystrom
7 years ago (2013-12-13 19:11:24 UTC) #5
Message was sent while issue was closed.
On 2013/11/05 06:57:37, Søren Gjesse wrote:
> Bob, what about the Windows batch file pub.bat?

Good question! My Windows box was in a bad state when I sent this out.

I've decided to not land this patch anyway. dart2js isn't doing this, so pub
shouldn't have to either. We've added another workaround to try to ensure
dart2js doesn't use too much memory.

Powered by Google App Engine
This is Rietveld 408576698