Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 51333006: Reapply "Do not directly load smi constants larger than a 16 bit..." (Closed)

Created:
7 years, 1 month ago by Kevin Millikin (Google)
Modified:
7 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reapply "Do not directly load smi constants larger than a 16 bit..." Reapply "Do not directly load smi constants larger than a 16 bit payload on ia32" with a bugfix. The predicate Assembler::IsSafeSmi incorrectly returned true for non-smis on non-ia32 platforms. Original summary: Instead of emitting a large smi constant directly as an immediate, xor the smi with a random 32-bit cookie at compile time, emit code to move that into a register and then to xor the register with the cookie. Original codereview: https://codereview.chromium.org/48743002/ R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=29533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -40 lines) Patch
M runtime/vm/assembler_arm.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 4 chunks +18 lines, -1 line 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 5 chunks +27 lines, -31 lines 0 comments Download
M runtime/vm/locations.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 1 month ago (2013-10-30 10:48:14 UTC) #1
Florian Schneider
lgtm
7 years, 1 month ago (2013-10-30 11:18:24 UTC) #2
Kevin Millikin (Google)
7 years, 1 month ago (2013-10-30 11:38:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698