Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 51333005: Add Uint32x4List to typed_data (Closed)

Created:
7 years, 1 month ago by Cutch
Modified:
7 years, 1 month ago
Reviewers:
vsm, srdjan, sra1, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -80 lines) Patch
M runtime/lib/typed_data.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/typed_data.dart View 1 6 chunks +193 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 8 chunks +30 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 4 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 10 chunks +16 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 10 chunks +16 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 10 chunks +16 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 10 chunks +17 lines, -5 lines 0 comments Download
M runtime/vm/intrinsifier.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 5 chunks +14 lines, -9 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 2 3 chunks +99 lines, -2 lines 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A + tests/lib/typed_data/uint32x4_list_test.dart View 5 chunks +49 lines, -49 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Cutch
7 years, 1 month ago (2013-10-30 07:31:37 UTC) #1
Cutch
Extending CL to inline operations on Uint32x4List. Adding Srdjan for review.
7 years, 1 month ago (2013-10-30 09:26:14 UTC) #2
srdjan
LGTM, please add someone from dart2js team to review corresponding changes.
7 years, 1 month ago (2013-10-30 20:57:09 UTC) #3
Cutch
Adding Vijay for dart2js bits.
7 years, 1 month ago (2013-10-30 22:15:18 UTC) #4
siva
lgtm
7 years, 1 month ago (2013-10-30 22:47:00 UTC) #5
vsm
lgtm https://codereview.chromium.org/51333005/diff/30001/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/51333005/diff/30001/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode828 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:828: // [length]. However, [_checkIndex] only allows incides in ...
7 years, 1 month ago (2013-10-31 00:10:31 UTC) #6
siva
Adding sra since he did the original dart2js implementation of typeddata.
7 years, 1 month ago (2013-10-31 00:14:35 UTC) #7
Cutch
https://codereview.chromium.org/51333005/diff/30001/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/51333005/diff/30001/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode828 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:828: // [length]. However, [_checkIndex] only allows incides in the ...
7 years, 1 month ago (2013-10-31 04:54:39 UTC) #8
Cutch
On 2013/10/31 00:14:35, siva wrote: > Adding sra since he did the original dart2js implementation ...
7 years, 1 month ago (2013-10-31 04:55:52 UTC) #9
Cutch
7 years, 1 month ago (2013-10-31 04:58:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r29639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698