Issue 51233005: pkg/unittest: tiny cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 51233005: pkg/unittest: tiny cleanup (Closed)

Created:
7 years, 1 month ago by kevmoo-old

Modified:
7 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	pkg/unittest/lib/matcher.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	pkg/unittest/lib/src/numeric_matchers.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Siggi Cherem (dart-lang)

can you reexport the diff, seems to show something like the revert you did earlier.

7 years, 1 month ago (2013-10-29 21:49:37 UTC) #2

kevmoo-old

On 2013/10/29 21:49:37, Siggi Cherem (dart-lang) wrote: > can you reexport the diff, seems to ...

7 years, 1 month ago (2013-10-29 21:51:35 UTC) #3

Siggi Cherem (dart-lang)

lgtm thank you! much easier to see the difference =)

7 years, 1 month ago (2013-10-29 21:52:32 UTC) #4

kevmoo-old

7 years, 1 month ago (2013-10-29 22:01:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r29496 (presubmit successful).