Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 51223004: Mark corelib/list_test/01 as failing on dart2js. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark corelib/list_test/01 as failing on dart2js. See issue 14616. This behavior is now checked for by a test. Committed: https://code.google.com/p/dart/source/detail?r=29530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tests/corelib/corelib.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/list_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
Yes, I said I'd do this before committing the other CL :)
7 years, 1 month ago (2013-10-30 11:26:30 UTC) #1
Lasse Reichstein Nielsen
TBR
7 years, 1 month ago (2013-10-30 11:26:39 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 manually as r29530 (presubmit successful).
7 years, 1 month ago (2013-10-30 11:26:53 UTC) #3
Anders Johnsen
7 years, 1 month ago (2013-10-30 11:37:04 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698