Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 512043002: Improve document.appendText test as follow up to "Fix Try Dart newline handling on IE11" change. (Closed)

Created:
6 years, 3 months ago by aam-me
Modified:
6 years, 3 months ago
Reviewers:
ahe, Emily Fortuna, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve document.appendText test as a follow up to "Fix Try Dart newline handling on IE11". R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=39684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/html/element_add_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aam-me
aprelev@gmail.com changed reviewers: + ahe@google.com, blois@google.com, efortuna@google.com
6 years, 3 months ago (2014-08-28 00:18:50 UTC) #1
aam-me
This is to incorporate Peter's suggestion from https://codereview.chromium.org/494253002/#msg18 I missed. Please take a look when ...
6 years, 3 months ago (2014-08-28 00:18:50 UTC) #2
ahe
lgtm
6 years, 3 months ago (2014-08-28 05:17:05 UTC) #3
aam-me
6 years, 3 months ago (2014-08-28 22:35:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r39684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698