Issue 511483003: Revert "Fix scope/context behavior in await transformer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511483003: Revert "Fix scope/context behavior in await transformer." (Closed)

Created:
6 years, 3 months ago by Michael Lippautz (Google)

Modified:
6 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Fix scope/context behavior in await transformer." This reverts commit fb220928acc36cc9078f905bb185b4c32b9a5608. BUG= Committed: https://code.google.com/p/dart/source/detail?r=39573

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -67 lines)			Patch
M	runtime/vm/ast_transformer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/ast_transformer.cc	View	4 chunks	+4 lines, -10 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/parser.cc	View	7 chunks	+7 lines, -21 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/await_future_test.dart	View	2 chunks	+0 lines, -30 lines	0 comments	Download
M	tests/standalone/issue14236_test.dart	View	Binary file		0 comments	Download

Total messages: 4 (0 generated)

Michael Lippautz (Google)

mlippautz@google.com changed reviewers: + hausner@google.com

6 years, 3 months ago (2014-08-27 00:10:31 UTC) #1

Michael Lippautz (Google)

TBR -- cannot reproduce locally; will split the changes into two parts (parsing and scope ...

6 years, 3 months ago (2014-08-27 00:10:31 UTC) #2

Michael Lippautz (Google)

Committed patchset #1 manually as 39573 (presubmit successful).

6 years, 3 months ago (2014-08-27 00:10:52 UTC) #3

Message was sent while issue was closed.

lgtm