Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 511193002: Split analyzer2dart code into multiple source files (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
Johnni Winther, jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split analyzer2dart code into multiple source files So that the components can be tested. R=johnniwinther@google.com, jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -98 lines) Patch
M pkg/analyzer2dart/bin/analyzer2dart.dart View 2 chunks +13 lines, -98 lines 0 comments Download
A pkg/analyzer2dart/lib/src/closed_world.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/analyzer2dart/lib/src/driver.dart View 1 chunk +71 lines, -0 lines 0 comments Download
A pkg/analyzer2dart/lib/src/tree_shaker.dart View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Berry
paulberry@google.com changed reviewers: + johnniwinther@google.com, jwren@google.com
6 years, 3 months ago (2014-08-28 09:58:13 UTC) #1
Paul Berry
6 years, 3 months ago (2014-08-28 09:58:13 UTC) #2
jwren
On 2014/08/28 09:58:13, Paul Berry wrote: LGTM
6 years, 3 months ago (2014-08-28 10:12:15 UTC) #3
Johnni Winther
lgtm
6 years, 3 months ago (2014-08-28 10:26:52 UTC) #4
Paul Berry
6 years, 3 months ago (2014-08-28 10:46:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 39642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698