Issue 511143002: Start filling out analyzer2dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511143002: Start filling out analyzer2dart (Closed)

Created:
6 years, 3 months ago by Paul Berry

Modified:
6 years, 3 months ago

Reviewers:
jwren, scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Start filling out analyzer2dart R=jwren@google.com TBR=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39635

Patch Set 1 #

Total comments: 3

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -3 lines)			Patch
	M	pkg/analyzer2dart/bin/analyzer2dart.dart	View		1 chunk	+106 lines, -3 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 manually as 39635 (presubmit successful).

6 years, 3 months ago (2014-08-28 08:59:37 UTC) #2

scheglov

scheglov@google.com changed reviewers: + scheglov@google.com

6 years, 3 months ago (2014-08-28 16:52:49 UTC) #3

scheglov

6 years, 3 months ago (2014-08-28 16:52:49 UTC) #4

Message was sent while issue was closed.

Wow, a new shiny project :-)

https://codereview.chromium.org/511143002/diff/1/pkg/analyzer2dart/bin/analyz...
File pkg/analyzer2dart/bin/analyzer2dart.dart (right):

https://codereview.chromium.org/511143002/diff/1/pkg/analyzer2dart/bin/analyz...
pkg/analyzer2dart/bin/analyzer2dart.dart:57: Set<Element> _alreadyEnqueued = new
Set<Element>();
new HashSet<Element>() ?

https://codereview.chromium.org/511143002/diff/1/pkg/analyzer2dart/bin/analyz...
pkg/analyzer2dart/bin/analyzer2dart.dart:61: if (!_alreadyEnqueued.contains(e))
{
You could use if (!_alreadyEnqueued.add(e)) instead.

https://codereview.chromium.org/511143002/diff/1/pkg/analyzer2dart/bin/analyz...
pkg/analyzer2dart/bin/analyzer2dart.dart:69: Element e = _queue.removeAt(0);
List.removeLast() is much faster.
So, if the order is not important, we could use it instead.

Expand Messages | Collapse Messages