Issue 51113013: Reapply "Substitute types in generic superclasses and interfaces." .

Issue 51113013: Reapply "Substitute types in generic superclasses and interfaces." . (Closed)

Created:
7 years, 1 month ago by zarah

Modified:
7 years, 1 month ago

Reviewers:
Johnni Winther, ahe, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Substitute types in generic superclasses and interfaces." . This reverts commit r29553. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=29725

Patch Set 2 : Fix: use mangled name in type substituion and in get superclass handle case where the class has no … #

Total comments: 5

Patch Set 3 : Addressed comments. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+344 lines, -117 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	17 chunks	+120 lines, -62 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_rti.dart	View		4 chunks	+13 lines, -7 lines	0 comments	Download
M	tests/lib/lib.status	View		3 chunks	+4 lines, -10 lines	0 comments	Download
M	tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart	View		4 chunks	+25 lines, -10 lines	0 comments	Download
M	tests/lib/mirrors/generic_bounded_test.dart	View		5 chunks	+26 lines, -8 lines	0 comments	Download
M	tests/lib/mirrors/generic_f_bounded_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	tests/lib/mirrors/generic_superclass_test.dart	View	1	1 chunk	+120 lines, -0 lines	0 comments	Download
M	tests/lib/mirrors/generic_type_mirror_test.dart	View		4 chunks	+18 lines, -6 lines	0 comments	Download
M	tests/lib/mirrors/generics_substitution_test.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/51113013/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart File sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/51113013/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart#newcode885 sdk/lib/_internal/lib/js_mirrors.dart:885: * [_cachedTypeArguments]. Due to type substitution of for ...

7 years, 1 month ago (2013-10-31 14:38:48 UTC) #2

zarah

Committed patchset #3 manually as r29725 (presubmit successful).

7 years, 1 month ago (2013-11-01 07:51:40 UTC) #3

zarah

7 years, 1 month ago (2013-11-01 08:06:55 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/51113013/diff/20001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/51113013/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:885: * [_cachedTypeArguments]. Due to type
substitution of for instances
On 2013/10/31 14:38:48, Johnni Winther wrote:
> 'instances' -> 'instance'.

Done.

https://codereview.chromium.org/51113013/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:886: * superclasses the mangled name of
the class and hence this string is needed.
On 2013/10/31 14:38:48, Johnni Winther wrote:
> 'is needed.' -> 'is needed after [_cachedTypeArguments] has been computed.'

Done.

Expand Messages | Collapse Messages