Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 510613002: Add passive handle types PassiveObject and PassiveInstance to allow (Closed)

Created:
6 years, 3 months ago by siva
Modified:
6 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add passive handle type PassiveObject to allow creation and using handles for simple use in methods which expect handles without any need for dispatching methods. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -33 lines) Patch
M runtime/vm/object.h View 1 chunk +48 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 9 chunks +19 lines, -18 lines 0 comments Download
M runtime/vm/snapshot.h View 3 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 12 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
asiva@google.com changed reviewers: + iposva@google.com
6 years, 3 months ago (2014-08-27 00:23:47 UTC) #1
siva
Landing CL from Zach (passive handle implementation)
6 years, 3 months ago (2014-08-27 00:23:48 UTC) #2
Ivan Posva
LGTM -ip
6 years, 3 months ago (2014-08-27 00:44:41 UTC) #3
siva
6 years, 3 months ago (2014-08-27 01:00:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r39574 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698