New analyzer snapshot.

New analyzer snapshot.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=29765

[Brian Wilkerson, 2013-11-01 13:41:14]

LGTM once my comment has been addressed

https://codereview.chromium.org/51043010/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/Scanner.java
(right):

https://codereview.chromium.org/51043010/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/Scanner.java:373:
protected Token firstTokenImpl() {
We shouldn't need to rename this method. It seems like we should have been able
to resolve the shadowing (in IncrementalScanner) by returning
"this.firstToken()".

Of course, just to complicate matters more, this would be better Java code and
the translator would produce better Dart code if this method were renamed to
"getFirstToken()".

But if this method can't be renamed to "getFirstToken()", could we at least go
with something like "getFirstTokenInStream()"? (It's just so much richer in
semantics.)

[scheglov, 2013-11-01 19:14:29]

https://codereview.chromium.org/51043010/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/Scanner.java
(right):

https://codereview.chromium.org/51043010/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/Scanner.java:373:
protected Token firstTokenImpl() {
On 2013/11/01 13:41:15, Brian Wilkerson wrote:
> We shouldn't need to rename this method. It seems like we should have been
able
> to resolve the shadowing (in IncrementalScanner) by returning
> "this.firstToken()".
> 
> Of course, just to complicate matters more, this would be better Java code and
> the translator would produce better Dart code if this method were renamed to
> "getFirstToken()".
> 
> But if this method can't be renamed to "getFirstToken()", could we at least go
> with something like "getFirstTokenInStream()"? (It's just so much richer in
> semantics.)

Renamed to getFirstToken().

[Brian Wilkerson, 2013-11-01 19:22:28]

LGTM

[scheglov, 2013-11-01 19:25:01]

Committed patchset #2 manually as r29765 (presubmit successful).