Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 51043004: Remove uses of Options from tools directory. Fix platform_test. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove uses of Options from tools directory. Fix platform_test. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M tests/standalone/io/platform_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/coverage.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tools/ddbg.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/dom/docs/bin/docs.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/full-coverage.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/line_doc_comments.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-10-30 16:16:57 UTC) #1
Søren Gjesse
lgtm
7 years, 1 month ago (2013-10-30 16:17:56 UTC) #2
Bill Hesse
7 years, 1 month ago (2013-10-30 16:21:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698