Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
510383002:
Version stamp the async compiled output. (Closed)
|
Created:
6 years, 3 months ago by Bob Nystrom Modified:
6 years, 3 months ago Reviewers:
nweiz CC:
reviews_dartlang.org, Kevin Millikin (Google), erik.meijer Visibility:
Public. |
DescriptionVersion stamp the async compiled output.
R=nweiz@google.com
Committed: https://code.google.com/p/dart/source/detail?r=39671
Patch Set 1 #
Total comments: 3
Messages
Total messages: 8 (0 generated)
rnystrom@google.com changed reviewers: + nweiz@google.com
This lets us force the previously async compiled stuff to get recompiled when we take a new drop of the compiler. Basically, whenever we touch the DEPS file to bring a different revision of the package from github, we'll want to bump the number here too.
https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... File sdk/lib/_internal/pub/bin/async_compile.dart (right): https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... sdk/lib/_internal/pub/bin/async_compile.dart:16: const COMPILER_VERSION = "1"; Can we scrape the DEPS file for this instead? Having to remember to update both is going to be a pain.
https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... File sdk/lib/_internal/pub/bin/async_compile.dart (right): https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... sdk/lib/_internal/pub/bin/async_compile.dart:16: const COMPILER_VERSION = "1"; On 2014/08/28 17:55:29, nweiz wrote: > Can we scrape the DEPS file for this instead? Having to remember to update both > is going to be a pain. No, because the DEPS file isn't in most people's checkout because of the whole weird dart/dart svn/git shenanigans at the root of our repo. This also lets us recompile stuff when this script itself has changed. It's a bit of a chore, but I don't think it will happen *that* often, or by that many people.
lgtm https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... File sdk/lib/_internal/pub/bin/async_compile.dart (right): https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... sdk/lib/_internal/pub/bin/async_compile.dart:16: const COMPILER_VERSION = "1"; On 2014/08/28 18:24:26, Bob Nystrom wrote: > On 2014/08/28 17:55:29, nweiz wrote: > > Can we scrape the DEPS file for this instead? Having to remember to update > both > > is going to be a pain. > > No, because the DEPS file isn't in most people's checkout because of the whole > weird dart/dart svn/git shenanigans at the root of our repo. > > This also lets us recompile stuff when this script itself has changed. It's a > bit of a chore, but I don't think it will happen *that* often, or by that many > people. In that case, at least add a comment to the DEPS line indicating that this should be updated when it changes.
On 2014/08/28 18:25:51, nweiz wrote: > lgtm > > https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... > File sdk/lib/_internal/pub/bin/async_compile.dart (right): > > https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... > sdk/lib/_internal/pub/bin/async_compile.dart:16: const COMPILER_VERSION = "1"; > On 2014/08/28 18:24:26, Bob Nystrom wrote: > > On 2014/08/28 17:55:29, nweiz wrote: > > > Can we scrape the DEPS file for this instead? Having to remember to update > > both > > > is going to be a pain. > > > > No, because the DEPS file isn't in most people's checkout because of the whole > > weird dart/dart svn/git shenanigans at the root of our repo. > > > > This also lets us recompile stuff when this script itself has changed. It's a > > bit of a chore, but I don't think it will happen *that* often, or by that many > > people. > > In that case, at least add a comment to the DEPS line indicating that this > should be updated when it changes. I tried, but I can't figure out how to get a svn checkout that includes the DEPS file. When I followed the instructions for getting the repo, I ended up with a directory that contains the DEPS file and a separate directory that contains the actual svn repo. Is there documentation somewhere on how to actually do this? Either way, this will be in a separate patch, so I'll commit this one now. - bob
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39671 (presubmit successful).
Message was sent while issue was closed.
On 2014/08/28 19:43:29, Bob Nystrom wrote: > On 2014/08/28 18:25:51, nweiz wrote: > > lgtm > > > > > https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... > > File sdk/lib/_internal/pub/bin/async_compile.dart (right): > > > > > https://codereview.chromium.org/510383002/diff/1/sdk/lib/_internal/pub/bin/as... > > sdk/lib/_internal/pub/bin/async_compile.dart:16: const COMPILER_VERSION = "1"; > > On 2014/08/28 18:24:26, Bob Nystrom wrote: > > > On 2014/08/28 17:55:29, nweiz wrote: > > > > Can we scrape the DEPS file for this instead? Having to remember to update > > > both > > > > is going to be a pain. > > > > > > No, because the DEPS file isn't in most people's checkout because of the > whole > > > weird dart/dart svn/git shenanigans at the root of our repo. > > > > > > This also lets us recompile stuff when this script itself has changed. It's > a > > > bit of a chore, but I don't think it will happen *that* often, or by that > many > > > people. > > > > In that case, at least add a comment to the DEPS line indicating that this > > should be updated when it changes. > > I tried, but I can't figure out how to get a svn checkout that includes the DEPS > file. When I followed the instructions for getting the repo, I ended up with a > directory that contains the DEPS file and a separate directory that contains the > actual svn repo. > > Is there documentation somewhere on how to actually do this? Probably not. Most of the details of our repo stuff are undocumented. > Either way, this will be in a separate patch, so I'll commit this one now. > > - bob |
||||||||||||||||||||||||||||||||||||||||||||||||||
