Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 509373003: Manually inline fixed-size list's forEach, to make it possible for the VM to optimize. (Closed)

Created:
6 years, 3 months ago by Anders Johnsen
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, karlklose
Visibility:
Public.

Description

Manually inline fixed-size list's forEach, to make it possible for the VM to optimize. BUG=https://code.google.com/p/dart/issues/detail?id=20715 R=iposva@google.com, lrn@google.com, vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39657

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Clean up iterator and force inline. #

Total comments: 2

Patch Set 4 : Force inline immutable lists. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M runtime/lib/array.dart View 1 2 3 chunks +18 lines, -16 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Anders Johnsen
ajohnsen@google.com changed reviewers: + lrn@google.com, vegorov@google.com
6 years, 3 months ago (2014-08-28 13:32:26 UTC) #1
Anders Johnsen
6 years, 3 months ago (2014-08-28 13:32:27 UTC) #2
kasperl
kasperl@google.com changed reviewers: + kasperl@google.com
6 years, 3 months ago (2014-08-28 13:45:18 UTC) #3
kasperl
https://codereview.chromium.org/509373003/diff/20001/runtime/lib/array.dart File runtime/lib/array.dart (right): https://codereview.chromium.org/509373003/diff/20001/runtime/lib/array.dart#newcode120 runtime/lib/array.dart:120: for (int i = 0; i < length; i++) ...
6 years, 3 months ago (2014-08-28 13:45:18 UTC) #4
Lasse Reichstein Nielsen
LGTM https://codereview.chromium.org/509373003/diff/20001/runtime/lib/array.dart File runtime/lib/array.dart (right): https://codereview.chromium.org/509373003/diff/20001/runtime/lib/array.dart#newcode378 runtime/lib/array.dart:378: IterableMixinWorkaround.forEach(this, f); Consider doing the same thing here.
6 years, 3 months ago (2014-08-28 13:47:43 UTC) #5
Anders Johnsen
Added force inline of some _List methods (PTAL Slava). https://codereview.chromium.org/509373003/diff/20001/runtime/lib/array.dart File runtime/lib/array.dart (right): https://codereview.chromium.org/509373003/diff/20001/runtime/lib/array.dart#newcode120 runtime/lib/array.dart:120: ...
6 years, 3 months ago (2014-08-28 14:20:13 UTC) #6
Vyacheslav Egorov (Google)
LGTM https://codereview.chromium.org/509373003/diff/40001/runtime/vm/method_recognizer.h File runtime/vm/method_recognizer.h (right): https://codereview.chromium.org/509373003/diff/40001/runtime/vm/method_recognizer.h#newcode293 runtime/vm/method_recognizer.h:293: V(_ImmutableList, get:length, ImmutableArrayLength, 274917727) \ Which iterator is ...
6 years, 3 months ago (2014-08-28 14:35:23 UTC) #7
Anders Johnsen
Added immutable lists. PTAL https://codereview.chromium.org/509373003/diff/40001/runtime/vm/method_recognizer.h File runtime/vm/method_recognizer.h (right): https://codereview.chromium.org/509373003/diff/40001/runtime/vm/method_recognizer.h#newcode293 runtime/vm/method_recognizer.h:293: V(_ImmutableList, get:length, ImmutableArrayLength, 274917727) \ ...
6 years, 3 months ago (2014-08-28 14:45:57 UTC) #8
Ivan Posva
iposva@google.com changed reviewers: + iposva@google.com
6 years, 3 months ago (2014-08-28 15:07:00 UTC) #9
Ivan Posva
LGTM -ip
6 years, 3 months ago (2014-08-28 15:07:00 UTC) #10
Vyacheslav Egorov (Google)
lgtm
6 years, 3 months ago (2014-08-28 15:07:09 UTC) #11
Anders Johnsen
6 years, 3 months ago (2014-08-28 15:10:26 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 39657 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698