Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 50833003: Updated rectangle documentation to explain coordinate system. (Closed)

Created:
7 years, 1 month ago by Emily Fortuna
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updated rectangle documentation to explain coordinate system. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=29617

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M sdk/lib/math/rectangle.dart View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Improved Rectangle docs based on recent bugs filed.
7 years, 1 month ago (2013-10-31 00:26:58 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/50833003/diff/40001/sdk/lib/math/rectangle.dart File sdk/lib/math/rectangle.dart (right): https://codereview.chromium.org/50833003/diff/40001/sdk/lib/math/rectangle.dart#newcode10 sdk/lib/math/rectangle.dart:10: * directed to the right but y directed ...
7 years, 1 month ago (2013-10-31 00:36:59 UTC) #2
Emily Fortuna
7 years, 1 month ago (2013-10-31 00:57:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698