Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 508203002: Rename some bools in the analysis server API. (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -87 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisStatus.java View 5 chunks +12 lines, -12 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 7 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 25 chunks +44 lines, -44 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/integration/server/status_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Berry
paulberry@google.com changed reviewers: + brianwilkerson@google.com, jwren@google.com
6 years, 3 months ago (2014-08-27 15:59:45 UTC) #1
Paul Berry
6 years, 3 months ago (2014-08-27 15:59:45 UTC) #2
jwren
On 2014/08/27 15:59:45, Paul Berry wrote: LGTM
6 years, 3 months ago (2014-08-27 16:29:19 UTC) #3
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-08-27 16:31:58 UTC) #4
Paul Berry
6 years, 3 months ago (2014-08-27 16:40:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 39604 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698