Create isolates in a separate thread.

Create isolates in a separate thread.

Previously the parent isolate waited for the child isolate to fully
load, which was not ideal.  This change fixes that.

If you run on mac, you may need to raise your open file limit to make mandel_isolate_test pass:

ulimit -n 1024

Default open file limit on the mac is low.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39617

[turnidge, 2014-08-27 17:50:51]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2014-08-27 18:18:43]

I wonder if the ulimit -n 1024 could be incorporated into test.py on Mac.

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate.cc#newco...
runtime/lib/isolate.cc:147: ReportError("Isolate spawn is not supported in this
Dart embedding.\n");
What about: "Isolate spawn is not supported by this Dart embedder."?

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate_patch.dart
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate_patch.da...
runtime/lib/isolate_patch.dart:264: assert(readyMessage is List);
These asserts will only trigger in checked mode. Should you do:

if (readyMessage is String) {
  completer.completeError...
} else if ((readyMessage is List) && (readyMessage.length == 2)) {
  completer.complete
} else {
  completer.completeError...
}

?

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate_patch.da...
runtime/lib/isolate_patch.dart:302: completer.complete(new Isolate(controlPort,
Duplicate code from above? Perhaps you can extract this entire closure into a
utility function.

[Cutch, 2014-08-27 18:31:35]

lgtm

[turnidge, 2014-08-27 19:28:59]

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate.cc#newco...
runtime/lib/isolate.cc:147: ReportError("Isolate spawn is not supported in this
Dart embedding.\n");
On 2014/08/27 18:18:42, Cutch wrote:
> What about: "Isolate spawn is not supported by this Dart embedder."?

Changed to "by this Dart implemation"

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate_patch.dart
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate_patch.da...
runtime/lib/isolate_patch.dart:264: assert(readyMessage is List);
Done.

On 2014/08/27 18:18:43, Cutch wrote:
> These asserts will only trigger in checked mode. Should you do:
> 
> if (readyMessage is String) {
>   completer.completeError...
> } else if ((readyMessage is List) && (readyMessage.length == 2)) {
>   completer.complete
> } else {
>   completer.completeError...
> }
> 
> ?

https://codereview.chromium.org/507913003/diff/1/runtime/lib/isolate_patch.da...
runtime/lib/isolate_patch.dart:302: completer.complete(new Isolate(controlPort,
On 2014/08/27 18:18:43, Cutch wrote:
> Duplicate code from above? Perhaps you can extract this entire closure into a
> utility function.

Extracted common code into new function spawnCommon.

[turnidge, 2014-08-27 19:47:10]

Committed patchset #2 (id:20001) manually as 39617 (presubmit successful).