Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 507823002: Properly serve descriptors containing URI-sensitive characters in pub. (Closed)

Created:
6 years, 3 months ago by nweiz
Modified:
6 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly serve descriptors containing URI-sensitive characters in pub. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=39570

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M sdk/lib/_internal/pub/test/test_pub.dart View 1 17 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 3 months ago (2014-08-26 21:09:54 UTC) #1
Bob Nystrom
One suggestion, but LGTM. https://codereview.chromium.org/507823002/diff/1/sdk/lib/_internal/pub/test/test_pub.dart File sdk/lib/_internal/pub/test/test_pub.dart (right): https://codereview.chromium.org/507823002/diff/1/sdk/lib/_internal/pub/test/test_pub.dart#newcode238 sdk/lib/_internal/pub/test/test_pub.dart:238: '..', '..', '..', '..', 'pkg')); ...
6 years, 3 months ago (2014-08-26 21:31:53 UTC) #2
nweiz
Code review changes
6 years, 3 months ago (2014-08-26 22:09:47 UTC) #3
nweiz
https://codereview.chromium.org/507823002/diff/1/sdk/lib/_internal/pub/test/test_pub.dart File sdk/lib/_internal/pub/test/test_pub.dart (right): https://codereview.chromium.org/507823002/diff/1/sdk/lib/_internal/pub/test/test_pub.dart#newcode238 sdk/lib/_internal/pub/test/test_pub.dart:238: '..', '..', '..', '..', 'pkg')); On 2014/08/26 21:31:53, Bob ...
6 years, 3 months ago (2014-08-26 22:09:52 UTC) #4
nweiz
6 years, 3 months ago (2014-08-26 22:29:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as 39570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698