Update List constructor documentation. Say that null is not a length.

Update List constructor documentation. Say that null is not a length.

R=floitsch@google.com, ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29522

[ngeoffray, 2013-10-29 12:13:50]

LGTM

https://codereview.chromium.org/50733002/diff/1/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/50733002/diff/1/sdk/lib/core/list.dart#newcode63
sdk/lib/core/list.dart:63: * The [length] must not be negative or null, if it is
provided.
-> Throws an [ArgumentError] if [length] is provided and it is negative or null.

https://codereview.chromium.org/50733002/diff/1/sdk/lib/core/list.dart#newcode73
sdk/lib/core/list.dart:73: * The [length] must not be negative or null.
-> Throws an [ArgumentError] if [length] is negative or null.

[Lasse Reichstein Nielsen, 2013-10-29 12:17:42]

Added tests. Dart2js still fails. Will check again before committing (likely
tomorrow), and update expectations first.

[Lasse Reichstein Nielsen, 2013-10-29 12:18:51]

https://codereview.chromium.org/50733002/diff/1/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/50733002/diff/1/sdk/lib/core/list.dart#newcode63
sdk/lib/core/list.dart:63: * The [length] must not be negative or null, if it is
provided.
I'd rather not say how it fails. It will most likely be an argument error. For
negative values, it could be a range error, or it might not.

[floitsch, 2013-10-29 16:25:20]

LGTM.

[Lasse Reichstein Nielsen, 2013-10-30 09:54:52]

Committed patchset #2 manually as r29522 (presubmit successful).

[Anders Johnsen, 2013-10-30 10:31:27]

DBC

https://codereview.chromium.org/50733002/diff/60001/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/50733002/diff/60001/sdk/lib/core/list.dart#ne...
sdk/lib/core/list.dart:73: * The [length] must not be negative or null.
"The [length] must be a positive integer." ?

and above.