Issue 507233002: Fix conditionally parsing await as keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 507233002: Fix conditionally parsing await as keyword. (Closed)

Created:
6 years, 3 months ago by Michael Lippautz (Google)

Modified:
6 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -4 lines)			Patch
M	runtime/vm/parser.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View		7 chunks	+16 lines, -4 lines	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/await_backwards_compatibility_test.dart	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/standalone/issue14236_test.dart	View		Binary file		0 comments	Download

Total messages: 4 (0 generated)

Michael Lippautz (Google)

mlippautz@google.com changed reviewers: + hausner@google.com

6 years, 3 months ago (2014-08-27 01:22:40 UTC) #1

Michael Lippautz (Google)

Separating previous CL's issues. Also added a test that solely checks for proper await parsing.

6 years, 3 months ago (2014-08-27 01:22:40 UTC) #2

Michael Lippautz (Google)

6 years, 3 months ago (2014-08-27 16:22:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 39602 (presubmit successful).