Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 50703011: fix csslib and watcher warnings (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom, terry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M pkg/csslib/lib/parser.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/pkg.status View 1 2 3 2 chunks +2 lines, -15 lines 0 comments Download
M pkg/watcher/lib/src/directory_watcher.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
A few more static warning fixes.
7 years, 1 month ago (2013-10-30 01:12:24 UTC) #1
terry
Thanks John, LGTM
7 years, 1 month ago (2013-10-30 14:16:36 UTC) #2
Bob Nystrom
LGTM.
7 years, 1 month ago (2013-10-30 16:10:56 UTC) #3
Jennifer Messerly
7 years, 1 month ago (2013-10-31 02:43:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r29632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698