Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 50703009: polymer warning clean (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : samples.status #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -49 lines) Patch
M pkg/pkg.status View 1 chunk +2 lines, -29 lines 2 comments Download
M pkg/polymer/lib/src/instance.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/polymer/test/bind_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/publish_attributes_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/test/publish_inherited_properties_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/test/register_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/test/template_distribute_dynamic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer_expressions/lib/filter.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M samples/samples.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jennifer Messerly
7 years, 1 month ago (2013-10-30 00:03:46 UTC) #1
Jennifer Messerly
oops, first version forgot to include samples.status. Fixed!
7 years, 1 month ago (2013-10-30 00:05:41 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/50703009/diff/30001/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/50703009/diff/30001/pkg/pkg.status#newcode359 pkg/pkg.status:359: polymer/test/build/utils_test: Pass I believe this doesn't override the ...
7 years, 1 month ago (2013-10-30 00:15:03 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/50703009/diff/30001/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/50703009/diff/30001/pkg/pkg.status#newcode359 pkg/pkg.status:359: polymer/test/build/utils_test: Pass On 2013/10/30 00:15:04, Siggi Cherem (dart-lang) wrote: ...
7 years, 1 month ago (2013-10-30 00:18:40 UTC) #4
Siggi Cherem (dart-lang)
On 2013/10/30 00:18:40, John Messerly wrote: > https://codereview.chromium.org/50703009/diff/30001/pkg/pkg.status > File pkg/pkg.status (right): > > https://codereview.chromium.org/50703009/diff/30001/pkg/pkg.status#newcode359 ...
7 years, 1 month ago (2013-10-30 00:20:18 UTC) #5
Jennifer Messerly
7 years, 1 month ago (2013-10-30 00:48:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r29505 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698