Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Issue 506973003: Clean up after r39484 and r39486. (Closed)

Created:
6 years, 3 months ago by nweiz
Modified:
6 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Clean up after r39484 and r39486. In particular, this adds CHANGELOG entries for packages that have been modified and fixes pub's barback dependency so it doesn't declare compatibility on an uncut release. This releases args, barback, http_parser, and shelf. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=39563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M pkg/args/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/barback/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/barback/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http_parser/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/shelf/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
nweiz@google.com changed reviewers: + rnystrom@google.com
6 years, 3 months ago (2014-08-26 18:31:28 UTC) #1
nweiz
Lasse: when updating packages (especially those you don't work on regularly), it's important to follow ...
6 years, 3 months ago (2014-08-26 18:31:28 UTC) #2
Bob Nystrom
lgtm
6 years, 3 months ago (2014-08-26 19:43:25 UTC) #3
nweiz
6 years, 3 months ago (2014-08-26 19:49:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39563 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698