Keep track of stack base whenever Dart code is invoked.

- Keep track of stack base whenever Dart code is invoked.

- Update stack limit based on stack base.

R=asiva@google.com, turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39613

[Cutch, 2014-08-26 15:05:55]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, turnidge@google.com

[Cutch, 2014-08-26 17:22:55]

PTAL

[turnidge, 2014-08-26 17:30:31]

lgtm

[turnidge, 2014-08-26 17:30:33]

lgtm

[siva, 2014-08-26 20:43:20]

As discussed offline :
- naming of the variables is inconsistent we decided to use
stack_base and stack_top
- the setting of stack_base needs to happen before every invocation of Dart code
(Dart_Invoke ?)
- the setting of stack_base can be done using the isolate structure (we are
discounting the case where an isolate can straddle two threads at the same
time). So we probably don't need the extra TLS

[Cutch, 2014-08-26 22:34:45]

PTAL

[siva, 2014-08-27 18:21:37]

lgtm

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/dart_e...
File runtime/vm/dart_entry.cc (right):

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/dart_e...
runtime/vm/dart_entry.cc:45: ASSERT(isolate_ != NULL);
ASSERT(isolate == Isolate::Current());

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/dart_e...
runtime/vm/dart_entry.cc:52: ~ScopedIsolateStackLimits() {
ASSERT(isolate_ == Isolate::Current());

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/isolat...
runtime/vm/isolate.h:279: bool GetProfilerStackBounds(uword* lower, uword*
upper);
bool GetProfilerStackBounds(uword* lower, uword* upper) const;

[Cutch, 2014-08-27 18:28:14]

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/dart_e...
File runtime/vm/dart_entry.cc (right):

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/dart_e...
runtime/vm/dart_entry.cc:45: ASSERT(isolate_ != NULL);
On 2014/08/27 18:21:37, siva wrote:
> ASSERT(isolate == Isolate::Current());
> 

Done.

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/dart_e...
runtime/vm/dart_entry.cc:52: ~ScopedIsolateStackLimits() {
On 2014/08/27 18:21:37, siva wrote:
> ASSERT(isolate_ == Isolate::Current());

Done.

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://chromiumcodereview.appspot.com/506933002/diff/40001/runtime/vm/isolat...
runtime/vm/isolate.h:279: bool GetProfilerStackBounds(uword* lower, uword*
upper);
On 2014/08/27 18:21:37, siva wrote:
> bool GetProfilerStackBounds(uword* lower, uword* upper) const;

Done.

[Cutch, 2014-08-27 18:28:56]

Committed patchset #4 (id:60001) manually as 39613 (presubmit successful).