Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Issue 506863002: Add support for running comparison of dart2js and dart2js with --dump-info output to the bots. (Closed)

Created:
6 years, 3 months ago by ricow1
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for running comparison of dart2js and dart2js with --dump-info output to the bots. This will compile with and without the flag, and compare the compiled output files (ignoring the json files). If you patch this in you can run this locally by doing: BUILDBOT_BUILDERNAME=dart2js-dump-info client/tools/buildbot_annotated_steps.py or BUILDBOT_BUILDERNAME=dart2js-dump-info python tools/bots/dart2js_dump_info.py R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M client/tools/buildbot_annotated_steps.py View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/bots/dart2js_dump_info.py View 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
ricow@google.com changed reviewers: + sra@google.com, tyoverby@google.com
6 years, 3 months ago (2014-08-26 09:42:36 UTC) #1
ricow1
I think it makes sense to iterate on this like this and potentially merge this ...
6 years, 3 months ago (2014-08-26 09:42:36 UTC) #2
ricow1
ricow@google.com changed reviewers: + whesse@google.com
6 years, 3 months ago (2014-08-26 10:33:40 UTC) #3
ricow1
6 years, 3 months ago (2014-08-26 10:33:40 UTC) #4
Bill Hesse
lgtm
6 years, 3 months ago (2014-08-26 10:43:43 UTC) #5
ricow1
6 years, 3 months ago (2014-08-26 11:06:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r39546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698