Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 50683007: Issue 14580. Fix for extra type arguments applying. (Closed)

Created:
7 years, 1 month ago by scheglov
Modified:
7 years, 1 month ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rollback codec.dart changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/InterfaceTypeImpl.java View 1 chunk +0 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 1 month ago (2013-10-30 17:19:30 UTC) #1
Brian Wilkerson
LGTM, once the changes to sdk/lib/convert/codec.dart have been backed out
7 years, 1 month ago (2013-10-30 17:33:46 UTC) #2
scheglov
7 years, 1 month ago (2013-10-30 17:50:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698