Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 506753002: Parameters and validation for the 'Extract Method' refactoring. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Parameters and validation for the 'Extract Method' refactoring. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -178 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 21 chunks +121 lines, -67 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 7 chunks +51 lines, -25 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 8 chunks +62 lines, -29 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 14 chunks +157 lines, -57 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 4 months ago (2014-08-25 22:55:36 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-26 04:33:02 UTC) #2
scheglov
6 years, 4 months ago (2014-08-26 05:48:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698