Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 506683003: Use isolate parameter while creating handles during class finalizers. (Closed)

Created:
6 years, 4 months ago by siva
Modified:
6 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use isolate parameter while creating handles during class finalizers. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=39568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M runtime/vm/class_finalizer.cc View 16 chunks +38 lines, -34 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
asiva@google.com changed reviewers: + regis@google.com
6 years, 4 months ago (2014-08-26 00:23:40 UTC) #1
siva
6 years, 4 months ago (2014-08-26 00:23:40 UTC) #2
regis
LGTM
6 years, 3 months ago (2014-08-26 15:27:48 UTC) #3
siva
6 years, 3 months ago (2014-08-26 20:54:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r39568 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698