Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 50633004: Remove uses of dart:io Options in dart2js and dartdoc. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom, ahe
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Andrei Mouravski, Emily Fortuna, Alan Knight
Visibility:
Public.

Description

Remove uses of dart:io Options in dart2js and dartdoc. BUG= R=ahe@google.com, rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=29456

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use arguments instead of args. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -59 lines) Patch
M runtime/bin/builtin.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 4 chunks +7 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/samples/darttags/darttags.dart View 1 chunk +4 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/samples/jsonify/jsonify.dart View 1 chunk +4 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/samples/leap/leap_server.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/dartdoc/bin/dartdoc.dart View 1 3 chunks +3 lines, -13 lines 0 comments Download
M utils/compiler/create_snapshot.dart View 5 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-10-29 15:41:08 UTC) #1
ahe
Thank you, Bill! LGTM [Attempting to CC people who might own dartdocs] https://codereview.chromium.org/50633004/diff/1/sdk/lib/_internal/compiler/implementation/dart2js.dart File sdk/lib/_internal/compiler/implementation/dart2js.dart ...
7 years, 1 month ago (2013-10-29 16:10:09 UTC) #2
Bob Nystrom
Dartdoc change LGTM! :)
7 years, 1 month ago (2013-10-29 16:30:42 UTC) #3
Bill Hesse
7 years, 1 month ago (2013-10-29 16:36:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698