Issue 50603010: Fixes to build.dart after Options() was removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50603010: Fixes to build.dart after Options() was removed (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
7 years, 1 month ago

Reviewers:
Bill Hesse, Jennifer Messerly, keertip

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -11 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/build.dart	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	pkg/polymer/lib/builder.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	samples/third_party/todomvc/build.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Siggi Cherem (dart-lang)

now that "new Options().arguments" is gone, we have to explicitly pass options in build.dart. This ...

7 years, 1 month ago (2013-10-30 20:24:20 UTC) #1

keertip

Looks good - difficult to test the editor bits. Patched it in and it works!

7 years, 1 month ago (2013-10-30 20:44:27 UTC) #3

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-10-30 20:46:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29584 (presubmit successful).