Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 50573002: Remove dart:platform library. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove dart:platform library. This reverts commits r29154, r29244, r29251, r29268, and r29272. The dart:io Platform class will not be moved to a dart:platform library. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -663 lines) Patch
M runtime/bin/builtin.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/bin/dartutils.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/dartutils.cc View 2 chunks +6 lines, -19 lines 0 comments Download
D runtime/lib/platform_patch.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D runtime/lib/platform_sources.gypi View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/bootstrap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/object_store.h View 4 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/vm.gypi View 6 chunks +0 lines, -87 lines 0 comments Download
D sdk/lib/_internal/lib/platform_patch.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/io/platform.dart View 1 chunk +1 line, -12 lines 0 comments Download
D sdk/lib/platform/platform.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D sdk/lib/platform/platform_sources.gypi View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/lib/lib.status View 3 chunks +0 lines, -8 lines 0 comments Download
D tests/lib/platform/environment_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/lib/platform/executable_arguments_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/lib/platform/executable_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/lib/platform/import_test.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D tests/lib/platform/isolate_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/lib/platform/local_hostname_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/lib/platform/number_of_processors_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/lib/platform/operating_system_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/lib/platform/package_root_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/lib/platform/path_separator_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/lib/platform/script_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/lib/platform/uri_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
M tests/standalone/io/uri_platform_test.dart View 1 chunk +32 lines, -2 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-10-29 10:26:46 UTC) #1
Anders Johnsen
lgtm
7 years, 1 month ago (2013-10-29 11:22:17 UTC) #2
Bill Hesse
7 years, 1 month ago (2013-10-29 11:33:58 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r29435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698