Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 50553002: Make Analyzer expect a compile time error where none exist. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, Brian Wilkerson
Visibility:
Public.

Description

Make Analyzer expect a compile time error where none exist. It seems most of the async library is suffering from this. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/lib/analyzer/analyze_library.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-29 09:59:28 UTC) #1
Lasse Reichstein Nielsen
The error is a reference before declaration at column 7939 of line 25 of a ...
7 years, 1 month ago (2013-10-29 10:00:32 UTC) #2
Anders Johnsen
lgtm
7 years, 1 month ago (2013-10-29 10:05:36 UTC) #3
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-29 10:06:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29427 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698