Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 50533005: Remove uses of dart:io Options from pub. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove uses of dart:io Options from pub. BUG= R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=29461

Patch Set 1 #

Patch Set 2 : Move errorArguments inside PubCommand class. #

Total comments: 4

Patch Set 3 : Remove global static copy of args. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M sdk/lib/_internal/pub/bin/pub.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-10-29 16:26:00 UTC) #1
Bob Nystrom
LGTM, though I generally think this is a change for the worse. Only passing command-line ...
7 years, 1 month ago (2013-10-29 16:58:51 UTC) #2
Bill Hesse
https://codereview.chromium.org/50533005/diff/30001/sdk/lib/_internal/pub/bin/pub.dart File sdk/lib/_internal/pub/bin/pub.dart (right): https://codereview.chromium.org/50533005/diff/30001/sdk/lib/_internal/pub/bin/pub.dart#newcode24 sdk/lib/_internal/pub/bin/pub.dart:24: PubCommand.errorArguments = arguments; On 2013/10/29 16:58:52, Bob Nystrom wrote: ...
7 years, 1 month ago (2013-10-29 17:16:29 UTC) #3
Bill Hesse
7 years, 1 month ago (2013-10-29 17:19:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r29461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698