Issue 50523018: Cleanup StaticResolveType, it does not seem to be used anywhere.

Issue 50523018: Cleanup StaticResolveType, it does not seem to be used anywhere. (Closed)

Created:
7 years, 1 month ago by siva

Modified:
7 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanup StaticResolveType, it does not seem to be used anywhere. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=29696

Patch Set 3 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -84 lines)			Patch
M	runtime/lib/isolate.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View	1 2	4 chunks	+4 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View		5 chunks	+5 lines, -10 lines	0 comments	Download
M	runtime/vm/resolver.h	View	1 2	2 chunks	+2 lines, -14 lines	0 comments	Download
M	runtime/vm/resolver.cc	View	1 2	3 chunks	+7 lines, -34 lines	0 comments	Download
M	runtime/vm/resolver_test.cc	View		4 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/50523018/diff/90001/runtime/vm/resolver.cc File runtime/vm/resolver.cc (right): https://codereview.chromium.org/50523018/diff/90001/runtime/vm/resolver.cc#newcode205 runtime/vm/resolver.cc:205: return cls.LookupStaticFunction(function_name); ResolveStaticByName is now just a redirect ...

7 years, 1 month ago (2013-10-31 18:48:42 UTC) #2

siva

https://codereview.chromium.org/50523018/diff/90001/runtime/vm/resolver.cc File runtime/vm/resolver.cc (right): https://codereview.chromium.org/50523018/diff/90001/runtime/vm/resolver.cc#newcode205 runtime/vm/resolver.cc:205: return cls.LookupStaticFunction(function_name); I removed the function, PTAL. On 2013/10/31 ...

7 years, 1 month ago (2013-10-31 20:08:41 UTC) #3

siva

7 years, 1 month ago (2013-10-31 20:42:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r29696 (presubmit successful).

Expand Messages | Collapse Messages