Issue 50523010: Remove js_interop_3_test.dart which tests sync ports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50523010: Remove js_interop_3_test.dart which tests sync ports (Closed)

Created:
7 years, 1 month ago by justinfagnani

Modified:
7 years, 1 month ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove js_interop_3_test.dart which tests sync ports BUG= Committed: https://code.google.com/p/dart/source/detail?r=29583

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -56 lines)			Patch
	D	tests/html/js_interop_3_test.dart	View		1 chunk	+0 lines, -56 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

justinfagnani

Committed patchset #1 manually as r29583 (presubmit successful).

7 years, 1 month ago (2013-10-30 20:17:16 UTC) #1

vsm

lgtm Looks like js_interop_2 is failing as well. Are you removing that also? Can you ...

7 years, 1 month ago (2013-10-30 20:36:29 UTC) #2

justinfagnani

7 years, 1 month ago (2013-10-30 20:48:15 UTC) #3

Message was sent while issue was closed.

On 2013/10/30 20:36:29, vsm wrote:
> lgtm
> 
> Looks like js_interop_2 is failing as well.  Are you removing that also?
> 
> Can you remove all references to this test in the html.status file in the same
> directory?

Yes, just submitted that one change before my tests completed since I knew it
had to go.

Expand Messages | Collapse Messages