Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 504973002: Updating Android library dependencies (Closed)

Created:
6 years, 4 months ago by blois
Modified:
6 years, 3 months ago
Reviewers:
zra, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Emily Fortuna
Visibility:
Public.

Description

Updating Android library dependencies We ran into some linker issues on gen_snapshot after upgrading to to Ubuntu 14.04 where it was unable to resolve pthread_condattr_setclock. I'm not sure if an additional dependency was added for this, or if the declaration moved. The core issue though is that in cross-compilations, some of the necessary dependencies were being added as 'linux', but this is not the case when compiling for host when the target is Android. The gen_snapshot target was accounting for this by adding the dependencies for android itself, but instead it should be done at the targets. The fix here is to move the dependencies from gen_snapshot and onto the targets as conditional OS=android, and to include the same set of libraries. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39972

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M runtime/bin/bin.gypi View 2 chunks +7 lines, -8 lines 0 comments Download
M runtime/vm/vm.gypi View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
6 years, 4 months ago (2014-08-25 21:16:59 UTC) #1
blois
On 2014/08/25 21:16:59, blois wrote: ping!
6 years, 3 months ago (2014-08-26 17:55:07 UTC) #2
blois
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-26 22:32:31 UTC) #3
Ivan Posva
LGTM -ip
6 years, 3 months ago (2014-08-28 18:03:55 UTC) #4
blois
6 years, 3 months ago (2014-09-08 15:59:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 39972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698