Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 504953002: Optimize "smi or old" filter in scavenger. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Optimize "smi or old" filter in scavenger into a single branch. Consistently speeds up SplayHarder by ~3-6% on ia32. Impact on ARM varies greatly between runs... R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M runtime/vm/raw_object.h View 1 chunk +13 lines, -1 line 0 comments Download
M runtime/vm/scavenger.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
koda@google.com changed reviewers: + iposva@google.com
6 years, 3 months ago (2014-08-25 21:43:47 UTC) #1
koda
6 years, 3 months ago (2014-08-25 21:44:26 UTC) #2
Ivan Posva
LGTM -ip
6 years, 3 months ago (2014-08-25 22:47:19 UTC) #3
koda
6 years, 3 months ago (2014-08-26 17:05:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r39557 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698