Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 50463005: Don't skip tests on machines without git. (Closed)

Created:
7 years, 1 month ago by Bob Nystrom
Modified:
7 years, 1 month ago
Reviewers:
nweiz, kustermann
CC:
reviews_dartlang.org, Ivan Posva, kustermann
Visibility:
Public.

Description

Don't skip tests on machines without git. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=29490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M sdk/lib/_internal/pub/test/test_pub.dart View 3 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
This removes the special handling from pub for running tests on machines without git installed. ...
7 years, 1 month ago (2013-10-29 20:23:28 UTC) #1
nweiz
lgtm
7 years, 1 month ago (2013-10-29 20:57:10 UTC) #2
Bob Nystrom
Committed patchset #1 manually as r29490 (presubmit successful).
7 years, 1 month ago (2013-10-29 20:59:38 UTC) #3
kustermann
7 years, 1 month ago (2013-10-30 00:44:09 UTC) #4
Message was sent while issue was closed.
Thank you very much, bob :)

Powered by Google App Engine
This is Rietveld 408576698