Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 504133002: Version 1.6.0 (Closed)

Created:
6 years, 3 months ago by ricow1
Modified:
6 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Version 1.6.0 Fixup deps files and VERSION file on 1.6 branch R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39553

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M dart/tools/VERSION View 1 1 chunk +3 lines, -3 lines 0 comments Download
M deps/all.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M deps/clank.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M deps/dartium.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M deps/standalone.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 3 months ago (2014-08-26 13:25:30 UTC) #1
Bill Hesse
LGTM, with comments. https://codereview.chromium.org/504133002/diff/1/dart/tools/VERSION File dart/tools/VERSION (right): https://codereview.chromium.org/504133002/diff/1/dart/tools/VERSION#newcode26 dart/tools/VERSION:26: CHANNEL dev stable?
6 years, 3 months ago (2014-08-26 13:34:46 UTC) #2
ricow1
https://codereview.chromium.org/504133002/diff/1/dart/tools/VERSION File dart/tools/VERSION (right): https://codereview.chromium.org/504133002/diff/1/dart/tools/VERSION#newcode26 dart/tools/VERSION:26: CHANNEL dev On 2014/08/26 13:34:46, Bill Hesse wrote: > ...
6 years, 3 months ago (2014-08-26 13:37:39 UTC) #3
ricow1
6 years, 3 months ago (2014-08-26 13:38:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r39553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698