Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 50413005: Reapply "Remove @deprecated features." (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed uses of deprecated features too. #

Patch Set 3 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -140 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/example/parser_driver.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/example/scanner_driver.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_io.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/services/runtime/coverage/coverage_impl.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/bidi_formatter.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/logging/lib/logging.dart View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/logging/test/logging_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/observe/lib/src/observable.dart View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/polymer/lib/component_build.dart View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/pattern_descriptor.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/unittest/lib/src/iterable_matchers.dart View 2 chunks +1 line, -7 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M samples/build_dart/build.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/survey/web/elements/question/question_element.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/file.dart View 2 chunks +0 lines, -30 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 2 chunks +0 lines, -6 lines 0 comments Download
M tests/lib/mirrors/library_uri_io_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/http_launch_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_test.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tests/standalone/io/file_fuzz_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_non_ascii_sync_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_non_ascii_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 5 chunks +9 lines, -9 lines 0 comments Download
M tests/standalone/io/link_async_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/link_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_non_ascii_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_working_directory_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/regress_7679_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M utils/compiler/create_snapshot.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Lasse Reichstein Nielsen
I had to remove some uses of the deprecated features too. I hope I have ...
7 years, 1 month ago (2013-10-29 15:43:38 UTC) #1
Søren Gjesse
lgtm, thanks for doing this
7 years, 1 month ago (2013-10-29 20:21:26 UTC) #2
scheglov
LGTM analyzer changes
7 years, 1 month ago (2013-10-29 20:34:02 UTC) #3
Cutch
I have my own CL pending for the vmservice changes.
7 years, 1 month ago (2013-10-30 07:30:26 UTC) #4
Lasse Reichstein Nielsen
On 2013/10/30 07:30:26, Cutch wrote: > I have my own CL pending for the vmservice ...
7 years, 1 month ago (2013-10-30 08:58:04 UTC) #5
Cutch
I doubt it will be committed today. Reviewers haven't gotten around to it. Go ahead ...
7 years, 1 month ago (2013-10-30 09:04:44 UTC) #6
Lasse Reichstein Nielsen
Excellent. Thanks!
7 years, 1 month ago (2013-10-30 10:25:58 UTC) #7
Lasse Reichstein Nielsen
Committed patchset #3 manually as r29535 (presubmit successful).
7 years, 1 month ago (2013-10-30 12:09:40 UTC) #8
srdjan
7 years, 1 month ago (2013-10-30 23:25:07 UTC) #9
Message was sent while issue was closed.
FYI: this CL seems to have broken VanillaCompileDart2JS benchmark.

Powered by Google App Engine
This is Rietveld 408576698