Issue 50413003: TraceBuffer implementation with tests

Issue 50413003: TraceBuffer implementation with tests (Closed)

Created:
7 years, 1 month ago by Cutch

Modified:
7 years, 1 month ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

TraceBuffer implementation with tests R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30237

Patch Set 4 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+285 lines, -0 lines)			Patch
A	runtime/vm/trace_buffer.h	View	1 2 3	1 chunk	+61 lines, -0 lines	0 comments	Download
A	runtime/vm/trace_buffer.cc	View	1 2 3	1 chunk	+121 lines, -0 lines	0 comments	Download
A	runtime/vm/trace_buffer_test.cc	View	1 2	1 chunk	+100 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

srdjan

DBC https://codereview.chromium.org/50413003/diff/30001/runtime/vm/trace_buffer_test.cc File runtime/vm/trace_buffer_test.cc (right): https://codereview.chromium.org/50413003/diff/30001/runtime/vm/trace_buffer_test.cc#newcode20 runtime/vm/trace_buffer_test.cc:20: } 'delete trace_buffer', here and elsewhere below.

7 years, 1 month ago (2013-10-29 15:21:19 UTC) #2

Cutch

https://codereview.chromium.org/50413003/diff/30001/runtime/vm/trace_buffer_test.cc File runtime/vm/trace_buffer_test.cc (right): https://codereview.chromium.org/50413003/diff/30001/runtime/vm/trace_buffer_test.cc#newcode20 runtime/vm/trace_buffer_test.cc:20: } On 2013/10/29 15:21:19, srdjan wrote: > 'delete trace_buffer', ...

7 years, 1 month ago (2013-10-29 23:51:40 UTC) #3

Ivan Posva

LGTM -ip https://codereview.chromium.org/50413003/diff/90001/runtime/vm/trace_buffer.cc File runtime/vm/trace_buffer.cc (right): https://codereview.chromium.org/50413003/diff/90001/runtime/vm/trace_buffer.cc#newcode111 runtime/vm/trace_buffer.cc:111: trace_entry.AddProperty("time", entry.seconds); Could also convert from micros ...

7 years, 1 month ago (2013-11-07 22:36:28 UTC) #4

srdjan

DBC https://codereview.chromium.org/50413003/diff/90001/runtime/vm/trace_buffer.h File runtime/vm/trace_buffer.h (right): https://codereview.chromium.org/50413003/diff/90001/runtime/vm/trace_buffer.h#newcode45 runtime/vm/trace_buffer.h:45: intptr_t ring_capacity_; const?

7 years, 1 month ago (2013-11-07 22:53:00 UTC) #5

Cutch

https://codereview.chromium.org/50413003/diff/90001/runtime/vm/trace_buffer.cc File runtime/vm/trace_buffer.cc (right): https://codereview.chromium.org/50413003/diff/90001/runtime/vm/trace_buffer.cc#newcode111 runtime/vm/trace_buffer.cc:111: trace_entry.AddProperty("time", entry.seconds); On 2013/11/07 22:36:28, Ivan Posva wrote: > ...

7 years, 1 month ago (2013-11-13 17:33:13 UTC) #6

Cutch

7 years, 1 month ago (2013-11-13 17:50:00 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 manually as r30237 (presubmit successful).

Expand Messages | Collapse Messages