Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 50373003: Expose the cancelOnError in the StreamController.addStream. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Expose the cancelOnError in the StreamController.addStream. Type tests, so this would have been caught. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M sdk/lib/async/stream_controller.dart View 2 chunks +20 lines, -18 lines 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-29 11:18:54 UTC) #1
Anders Johnsen
lgtm
7 years, 1 month ago (2013-10-29 11:20:32 UTC) #2
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-29 11:28:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698