Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 503363002: Defer execution of the main isolate's entry point until the message loop. (Closed)

Created:
6 years, 3 months ago by turnidge
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Defer execution of the main isolate's entry point until the message loop. This allows us to know more accurately the stack limit while running main. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39558

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M runtime/bin/main.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 1 1 chunk +21 lines, -2 lines 0 comments Download
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
turnidge@google.com changed reviewers: + johnmccutchan@google.com
6 years, 3 months ago (2014-08-26 16:58:45 UTC) #1
turnidge
6 years, 3 months ago (2014-08-26 16:58:45 UTC) #2
Cutch
lgtm
6 years, 3 months ago (2014-08-26 17:00:27 UTC) #3
turnidge
6 years, 3 months ago (2014-08-26 17:21:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as 39558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698